Browse Source

Add cleaner const naming

main
Valentin BOUVAREL 3 years ago
parent
commit
32ba438edd
  1. 8
      gestform.py
  2. 14
      tests/tests_gestform.py

8
gestform.py

@ -7,6 +7,8 @@ from random import shuffle
MIN = -1000 MIN = -1000
MAX = 1000 MAX = 1000
GESTE = 3
FORME = 5
def generate_numbers_list(mini: int, maxi: int) -> List[int]: def generate_numbers_list(mini: int, maxi: int) -> List[int]:
@ -22,11 +24,11 @@ def randomise_with_iterator(list_from: List[int]) -> int:
def gestformation(number: int) -> str: def gestformation(number: int) -> str:
"""Transform a number to a string depends on modularity""" """Transform a number to a string depends on modularity"""
if number % 3 == 0 and number % 5 == 0: if number % GESTE == 0 and number % FORME == 0:
return "GestForm" return "GestForm"
elif number % 5 == 0: elif number % FORME == 0:
return "Forme" return "Forme"
elif number % 3 == 0: elif number % GESTE == 0:
return "Geste" return "Geste"
return number return number

14
tests/tests_gestform.py

@ -3,7 +3,7 @@ from unittest import TestCase
from gestform import ( from gestform import (
generate_numbers_list, MIN, MAX, generate_numbers_list, MIN, MAX,
randomise_with_iterator, randomise_with_iterator,
gestformation, gestformation
) )
@ -38,42 +38,42 @@ class GestFormTest(TestCase):
) )
] ]
def test_geste_modulo_3(self): def test_geste_modulo(self):
gest_numbers = [-999, -333, 3, 9, 18, 1002] gest_numbers = [-999, -333, 3, 9, 18, 1002]
for i in gest_numbers: for i in gest_numbers:
with self.subTest(i): with self.subTest(i):
result = gestformation(i) result = gestformation(i)
self.assertEqual(result, "Geste") self.assertEqual(result, "Geste")
def test_not_geste_modulo_3(self): def test_not_geste_modulo(self):
gest_numbers = [-998, -332, 2, 10, 19, 1000] gest_numbers = [-998, -332, 2, 10, 19, 1000]
for i in gest_numbers: for i in gest_numbers:
with self.subTest(i): with self.subTest(i):
result = gestformation(i) result = gestformation(i)
self.assertNotEqual(result, "Geste") self.assertNotEqual(result, "Geste")
def test_forme_modulo_5(self): def test_forme_modulo(self):
gest_numbers = [-5555, -50, 5, 40, 70, 995] gest_numbers = [-5555, -50, 5, 40, 70, 995]
for i in gest_numbers: for i in gest_numbers:
with self.subTest(i): with self.subTest(i):
result = gestformation(i) result = gestformation(i)
self.assertEqual(result, "Forme") self.assertEqual(result, "Forme")
def test_not_forme_modulo_5(self): def test_not_forme_modulo(self):
gest_numbers = [-998, -332, 2, 14, 19, 1111] gest_numbers = [-998, -332, 2, 14, 19, 1111]
for i in gest_numbers: for i in gest_numbers:
with self.subTest(i): with self.subTest(i):
result = gestformation(i) result = gestformation(i)
self.assertNotEqual(result, "Forme") self.assertNotEqual(result, "Forme")
def test_gestform_modulo_15(self): def test_gestform_modulo(self):
gest_numbers = [-1500, -60, 15, 105, 900, 1005] gest_numbers = [-1500, -60, 15, 105, 900, 1005]
for i in gest_numbers: for i in gest_numbers:
with self.subTest(i): with self.subTest(i):
result = gestformation(i) result = gestformation(i)
self.assertEqual(result, "GestForm") self.assertEqual(result, "GestForm")
def test_not_gestform_modulo_5(self): def test_not_gestform_modulo(self):
gest_numbers = [-998, -332, 2, 10, 19, 1000] gest_numbers = [-998, -332, 2, 10, 19, 1000]
for i in gest_numbers: for i in gest_numbers:
with self.subTest(i): with self.subTest(i):

Loading…
Cancel
Save